fix(kotlin): add @Valid annotation for cascade validation#2593
Open
alexanderxfgl-bit wants to merge 1 commit into
Open
fix(kotlin): add @Valid annotation for cascade validation#2593alexanderxfgl-bit wants to merge 1 commit into
alexanderxfgl-bit wants to merge 1 commit into
Conversation
…ject/reference fields The Kotlin ConstraintsPreset was missing the @Valid annotation for array, object, and reference properties, which disabled cascading validation. This is the same issue that was fixed for the Java generator in asyncapi#2175. Changes: - Add @Valid annotation for ConstrainedArrayModel, ConstrainedObjectModel, and ConstrainedReferenceModel properties - Add javax.validation.Valid (or jakarta.validation.Valid) import - Add test case verifying @Valid is rendered for nested object and array props Fixes asyncapi#2573
✅ Deploy Preview for modelina canceled.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
The Kotlin
ConstraintsPresetwas missing the@Validannotation for array, object, and reference properties, effectively disabling cascading validation. This is the same issue that was fixed for the Java generator in #2175.Without
@Valid, validation constraints on nested objects and array elements are never triggered, so invalid data in nested structures passes silently.Changes
@Validannotation (@get:Validin Kotlin syntax) forConstrainedArrayModel,ConstrainedObjectModel, andConstrainedReferenceModelpropertiesjavax.validation.Valid(orjakarta.validation.ValidwhenuseJakarta: true) to imports@Validis rendered for nested object and array propertiesExample output
Related issue
Fixes #2573